Skip to content

fix(NewUserDialog): update group selection to prevent admin group from being assigned as subadmin #57233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 2 commits into from
Dec 30, 2025
Merged

fix(NewUserDialog): update group selection to prevent admin group from being assigned as subadmin #57233

Antreesy merged 2 commits into from
Dec 30, 2025
+11 −7

Conversation

@Arsalanulhaq
Copy link
Contributor

@Arsalanulhaq Arsalanulhaq commented Dec 23, 2025 •
edited
Loading

Summary

This pull request updates the group selection logic in the NewUserDialog.vue component to prevent users from being assigned as sub-admins of the admin group. The main change is the introduction of a new computed property from UserRow.vue to filter out the admin group from the selectable options for sub-admin assignment.

Group selection improvements:

  • The :options prop for the sub-admin group selection now uses the new availableSubAdminGroups computed property, ensuring the admin group is excluded from the list of assignable sub-admin groups.
  • Added the availableSubAdminGroups computed property, which filters out the admin group from availableGroups.

TODO

  • ...

Checklist

@Arsalanulhaq Arsalanulhaq requested a review from a team as a code owner December 23, 2025 10:43
@Arsalanulhaq Arsalanulhaq requested review from artonge, nfebe and susnux and removed request for a team December 23, 2025 10:43
@printminion-co printminion-co force-pushed the bugfix/prevent_admin_group_subadmin branch from 2feef0f to f59a590 Compare December 30, 2025 08:38
CarlSchwan
CarlSchwan approved these changes Dec 30, 2025
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint CI is failing but looks good.

And this does need the same code also in the backend, as we shouldn't rely only on client side verification ;)

@Arsalanulhaq
Copy link
Contributor Author

Arsalanulhaq commented Dec 30, 2025 •
edited
Loading

lint CI is failing but looks good.

And this does need the same code also in the backend, as we shouldn't rely only on client side verification ;)

@CarlSchwan Thanks for your review.
The backend checks are already there apps/provisioning_api/lib/Controller/UsersController.php.
The lint issue is not coming from this NewUserDialog.vue file

Antreesy
Antreesy reviewed Dec 30, 2025
View reviewed changes
@Arsalanulhaq Arsalanulhaq force-pushed the bugfix/prevent_admin_group_subadmin branch from f59a590 to a0d5b25 Compare December 30, 2025 10:31
@Arsalanulhaq
fix(NewUserDialog): update group selection to prevent admin group fro…
c81422e 
…m being assigned as subadmin

Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
@Arsalanulhaq Arsalanulhaq force-pushed the bugfix/prevent_admin_group_subadmin branch from a0d5b25 to c81422e Compare December 30, 2025 10:33
@Antreesy
Copy link
Contributor

Antreesy commented Dec 30, 2025

/compile

@Antreesy Antreesy added this to the Nextcloud 33 milestone Dec 30, 2025
@nextcloud-command
chore(assets): Recompile assets
a31d42d 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Antreesy Antreesy merged commit 752d90c into master Dec 30, 2025
136 of 140 checks passed
@Antreesy Antreesy deleted the bugfix/prevent_admin_group_subadmin branch December 30, 2025 12:26
@welcome
Copy link

welcome bot commented Dec 30, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@Antreesy
Copy link
Contributor

Antreesy commented Dec 30, 2025

/backport c81422e to stable32

@Antreesy
Copy link
Contributor

Antreesy commented Dec 30, 2025

/backport c81422e to stable31

This was referenced Dec 30, 2025
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@susnux susnux Awaiting requested review from susnux susnux is a code owner automatically assigned from nextcloud/server-frontend

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-frontend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: users and groups

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

5 participants

@Arsalanulhaq @Antreesy @CarlSchwan @nextcloud-command